Ticket #981 (closed 新規開発: 修正済)

Opened 10 years ago

Last modified 9 years ago

[フロント]MYページ

Reported by: kotani Owned by: kimoto
Priority: Milestone: EC-CUBE2.11.0 リファクタリングProject
Component: フロント Version: 2.11.0 β
Keywords: Cc:
修正済み: no

Description

▼リファクタリング対象ファイル
/mypage/LC_Page_Mypage.php
/mypage/LC_Page_Mypage_Change.php
/mypage/LC_Page_Mypage_ChangeComplete.php
/mypage/LC_Page_Mypage_Delivery.php
/mypage/LC_Page_Mypage_DeliveryAddr.php
/mypage/LC_Page_Mypage_DownLoad.php
/mypage/LC_Page_Mypage_Favorite.php
/mypage/LC_Page_Mypage_History.php
/mypage/LC_Page_Mypage_HistoryDetail.php
/mypage/LC_Page_Mypage_Login.php
/mypage/LC_Page_Mypage_LoginCheck.php
/mypage/LC_Page_Mypage_MailView.php
/mypage/LC_Page_Mypage_Order.php
/mypage/LC_Page_Mypage_Refusal.php
/mypage/LC_Page_Mypage_RefusalComplete.php


リファクタリングガイドライン
http://svn.ec-cube.net/open_trac/wiki/リファクタリングガイドライン


Change History

comment:1 Changed 10 years ago by kimoto

  • Owner changed from somebody to kimoto

comment:2 Changed 10 years ago by kimoto

  • Status changed from new to assigned

comment:3 Changed 10 years ago by kimoto

■終了 /mypage/LC_Page_Mypage_Change.php /mypage/LC_Page_Mypage_ChangeComplete.php /mypage/LC_Page_Mypage_Delivery.php /mypage/LC_Page_Mypage_Favorite.php /mypage/LC_Page_Mypage_History.php /mypage/LC_Page_Mypage_HistoryDetail.php /mypage/LC_Page_Mypage_Login.php /mypage/LC_Page_Mypage_MailView.php /mypage/LC_Page_Mypage_Order.php /mypage/LC_Page_Mypage_Refusal.php /mypage/LC_Page_Mypage_RefusalComplete.php

comment:4 Changed 10 years ago by kimoto

  • Status changed from assigned to closed
  • Resolution set to 修正済

comment:5 Changed 10 years ago by ghana

  • Status changed from closed to reopened
  • Resolution 修正済 deleted

LC_Page_AbstractMypage を Extends するクラス LC_Page_AbstractMypage_Ex を作ってその他の /mypage/LC_Page_Mypage_XX クラスでは LC_Page_AbstractMypage_Ex を継承するようにしてください。

comment:6 Changed 10 years ago by ghana

  • Status changed from reopened to closed
  • Resolution set to 修正済

r20162 で LC_Page_AbstractMypage を Extends するクラス LC_Page_AbstractMypage_Ex を作成、/mypage/LC_Page_Mypage_XX クラスでは LC_Page_AbstractMypage_Ex を継承するようにしました

comment:7 Changed 10 years ago by kotani

  • Status changed from closed to reopened
  • Resolution 修正済 deleted

/data/class/helper/SC_Helper_Customer.php
にて、
参照渡しとなっている引数に対して、呼び出し側で参照渡しにしているため、下記警告が出ています。

Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /mnt/working_copy/eccube211/data/class/helper/SC_Helper_Customer.php on line 406

Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /mnt/working_copy/eccube211/data/class/helper/SC_Helper_Customer.php on line 418

Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /mnt/working_copy/eccube211/data/class/helper/SC_Helper_Customer.php on line 419

Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /mnt/working_copy/eccube211/data/class/helper/SC_Helper_Customer.php on line 437

comment:8 Changed 10 years ago by kotani

  • Status changed from reopened to closed
  • Resolution set to 修正済

r20170 で修正しました。

comment:9 Changed 9 years ago by shutta

  • 修正済み unset

r20159 にて、LC_Page_Mypage_LoginCheck.phpが削除されているが、その際に削除漏れしているファイルを r21151 にて削除。

Note: See TracTickets for help on using tickets.