Ticket #970 (closed 新規開発: 修正済)

Opened 12 years ago

Last modified 12 years ago

[管理画面]商品管理（一部）

Reported by: kotani Owned by: somebody
Priority: 中 Milestone: EC-CUBE2.11.0 リファクタリングProject
Component: 管理画面 Version: 2.11.0 β
Keywords: Cc:
修正済み:

Description (last modified by Yammy) (diff)

▼リファクタリング対象ファイル
/admin/products/LC_Page_Admin_Products_ProductRank.php
/admin/products/LC_Page_Admin_Products_ProductSelect.php
/admin/products/LC_Page_Admin_Products_Review.php
/admin/products/LC_Page_Admin_Products_ReviewEdit.php

▼特記
下記ファイルの削除をお願いします。
/admin/products/LC_Page_Admin_Products_Trackback.php
/admin/products/LC_Page_Admin_Products_TrackbackEdit.php

リファクタリングガイドライン http://svn.ec-cube.net/open_trac/wiki/リファクタリングガイドライン

Change History

comment:1 Changed 12 years ago by Yammy

  • Owner changed from somebody to Yammy

comment:2 Changed 12 years ago by Yammy

  • Status changed from new to assigned
  • Description modified (diff)

comment:3 Changed 12 years ago by Yammy

  • Description modified (diff)

comment:4 in reply to: ↑ description Changed 12 years ago by Yammy

  • Description modified (diff)

kotani への返信

▼リファクタリング対象ファイル
/admin/products/LC_Page_Admin_Products_ProductRank.php
/admin/products/LC_Page_Admin_Products_ProductSelect.php
/admin/products/LC_Page_Admin_Products_Review.php
/admin/products/LC_Page_Admin_Products_ReviewEdit.php

▼特記
下記ファイルの削除をお願いします。
/admin/products/LC_Page_Admin_Products_Trackback.php
/admin/products/LC_Page_Admin_Products_TrackbackEdit.php

リファクタリングガイドライン
http://svn.ec-cube.net/open_trac/wiki/リファクタリングガイドライン

comment:5 Changed 12 years ago by Yammy

  • Description modified (diff)

comment:6 Changed 12 years ago by Yammy

  • Description modified (diff)

comment:7 Changed 12 years ago by Yammy

残

/admin/products/LC_Page_Admin_Products_Review.php /admin/products/LC_Page_Admin_Products_ReviewEdit.php

かな

comment:8 Changed 12 years ago by Yammy

  • Status changed from assigned to closed
  • Resolution set to 修正済

とりあえず出来るところまでをリファクタリング。

comment:9 Changed 12 years ago by kotani

  • Status changed from closed to reopened
  • Resolution 修正済 deleted

/admin/products/LC_Page_Admin_Products_Review.php
/admin/products/LC_Page_Admin_Products_ReviewEdit.php
のリファクタリングお願いします。

comment:10 Changed 12 years ago by naka

  • Owner changed from Yammy to naka
  • Status changed from reopened to new

以下2ファイル、こちらで対応致します。 /admin/products/LC_Page_Admin_Products_Review.php /admin/products/LC_Page_Admin_Products_ReviewEdit.php

comment:11 Changed 12 years ago by naka

  • Status changed from new to assigned

comment:12 Changed 12 years ago by naka

  • Status changed from assigned to closed
  • Resolution set to 修正済

ある程度のレベルまで対応しました。

comment:13 Changed 12 years ago by shutta

r20270 にて、(ある程度削除されていたが)トラックバック関連部分の削除しました。

comment:14 Changed 12 years ago by kotani

  • Status changed from closed to reopened
  • Resolution 修正済 deleted

vw_products_allclass を使っている部分が残っており、DBエラーが発生しています。

comment:15 Changed 12 years ago by kotani

  • Owner changed from naka to somebody
  • Status changed from reopened to new

comment:16 Changed 12 years ago by shutta

LC_Page_Admin_Products_ProductSelect.phpを、SC_FormParamを利用するようにリファクタリング(r20419)

comment:17 Changed 12 years ago by kotani

  • Status changed from new to closed
  • Resolution set to 修正済

バグを #1060 に移行し、本チケットはクローズします。

Note: See TracTickets for help on using tickets.