Changeset 22069 for branches/version-2_12-dev/data/class/helper/SC_Helper_Address.php

Timestamp:

2012/11/04 07:02:38 (14 years ago)

Author:

pineray

Message:

#1958 (別お届け先関連の処理をページクラスから分離)

関数名が冗長なので変更.
other_deliv_id だけで対象を特定できるので引数を整理.

File:

• branches/version-2_12-dev/data/class/helper/SC_Helper_Address.php (modified) (4 diffs)

branches/version-2_12-dev/data/class/helper/SC_Helper_Address.php

@@ -34 +34 @@
      * お届け先を登録
      *
-     * @param integer $customer_id
      * @param array $sqlval
-     * @param integer $other_deliv_id
      * @return array()
      */
-    function registAddress($customer_id, $sqlval, $other_deliv_id = '') {
+    function save($sqlval) {
         $objQuery =& SC_Query_Ex::getSingletonInstance();
+        $customer_id = $sqlval['customer_id'];
+        $other_deliv_id = $sqlval['other_deliv_id'];
 
+        // 顧客IDのチェック
+        if (is_null($customer_id) || !is_numeric($customer_id) || !preg_match("/^\d+$/", $customer_id)) {
+            SC_Utils_Ex::sfDispSiteError(FREE_ERROR_MSG, '', false, '顧客IDを正しく指定して下さい。');
+        }
         // 追加
         if (strlen($other_deliv_id == 0)) {
@@ -57 +61 @@
         // 変更
         } else {
-            $deliv_count = $objQuery->count('dtb_other_deliv','customer_id = ? AND other_deliv_id = ?' ,array($customer_id, $other_deliv_id));
+            $deliv_count = $objQuery->count('dtb_other_deliv','other_deliv_id = ?' ,array($other_deliv_id));
             if ($deliv_count != 1) {
                 SC_Utils_Ex::sfDispSiteError(FREE_ERROR_MSG, '', false, '一致する別のお届け先がありません。');
@@ -70 +74 @@
      * お届け先を取得
      *
-     * @param integer $customer_id
      * @param integer $other_deliv_id
      * @return array()
      */
-    function getAddress($customer_id, $other_deliv_id) {
+    function get($other_deliv_id) {
         $objQuery =& SC_Query_Ex::getSingletonInstance();
-        $address = $objQuery->select('*', 'dtb_other_deliv', 'customer_id = ? AND other_deliv_id = ?', array($customer_id, $other_deliv_id));
+        $address = $objQuery->select('*', 'dtb_other_deliv', 'other_deliv_id = ?', array($other_deliv_id));
         return $address ? $address[0] : FALSE;
     }
@@ -100 +103 @@
      * お届け先の削除
      *
-     * @param integer $customerId
      * @param integer $delivId
      * @return void
      */
-    function deleteAddress($customer_id, $other_deliv_id) {
-        $where      = 'customer_id = ? AND other_deliv_id = ?';
+    function delete($other_deliv_id) {
+        $where      = 'other_deliv_id = ?';
         $objQuery   =& SC_Query_Ex::getSingletonInstance();
-        $objQuery->delete('dtb_other_deliv', $where, array($customer_id, $other_deliv_id));
+        $objQuery->delete('dtb_other_deliv', $where, array($other_deliv_id));
     }