Changeset 21927 for branches/version-2_12-dev/data/class/helper/SC_Helper_Purchase.php

Timestamp:

2012/06/20 11:57:43 (14 years ago)

Author:

pineray

Message:

#1669 #1859 初期化漏れ、無駄な変数等

File:

• branches/version-2_12-dev/data/class/helper/SC_Helper_Purchase.php (modified) (7 diffs)

branches/version-2_12-dev/data/class/helper/SC_Helper_Purchase.php

@@ -122 +122 @@
         }
 
+        $arrParams = array();
         $arrParams['status'] = $orderStatus;
         if ($is_delete) {
@@ -271 +272 @@
         // 存在するカラムのみを対象とする
         $cols = $objQuery->listTableFields('dtb_order_temp');
+        $sqlval = array();
         foreach ($params as $key => $val) {
             if (in_array($key, $cols)) {
@@ -542 +544 @@
         $objQuery->setOrder('rank DESC');
         $payments = $objQuery->select('payment_id, payment_method, rule_max, upper_rule, note, payment_image, charge', 'dtb_payment', $where, $arrPaymentIds);
+        $arrPayment = array();
         foreach ($payments as $data) {
             // 下限と上限が設定されている
@@ -842 +845 @@
         $objProduct = new SC_Product_Ex();
         $i = 0;
+        $arrDetail = array();
         foreach ($cartItems as $item) {
             $p =& $item['productsClass'];
@@ -1068 +1072 @@
 
         if ($has_items) {
-            $objProduct = new SC_Product_Ex();
             foreach (array_keys($arrResults) as $shipping_id) {
                 $arrResults[$shipping_id]['shipment_item']
@@ -1136 +1139 @@
      * @return void
      */
-    function sfUpdateOrderStatus($orderId, $newStatus = null, $newAddPoint = null, $newUsePoint = null, &$sqlval) {
+    function sfUpdateOrderStatus($orderId, $newStatus = null, $newAddPoint = null, $newUsePoint = null, &$sqlval = array()) {
         $objQuery =& SC_Query_Ex::getSingletonInstance();
         $arrOrderOld = $objQuery->getRow('status, add_point, use_point, customer_id', 'dtb_order', 'order_id = ?', array($orderId));
@@ -1331 +1334 @@
      * 加える機会を与える.
      *
+     * $orderId が使われていない。
+     * 
      * @param integer $orderId 注文番号
      * @param SC_CartSession $objCartSession カート情報のインスタンス