Changeset 23459 for branches/version-2_13-dev/data/class/helper

Timestamp:

2014/05/29 14:40:57 (12 years ago)

Author:

pineray

Message:

#2515 無駄な処理を改善する for 2.13.3

カテゴリーID取得部分の処理を整理.

Location:

branches/version-2_13-dev/data/class/helper

Files:

• SC_Helper_Category.php (modified) (1 diff)
• SC_Helper_DB.php (modified) (1 diff)

branches/version-2_13-dev/data/class/helper/SC_Helper_Category.php

@@ -397 +397 @@
         return $objQuery->update($table, array(), $where, array(), $arrRawVal);
     }
+
+    /**
+     * 有効なカテゴリーIDかチェックする.
+     *
+     * @param int $category_id
+     * @param bool $include_deleted
+     * @return bool
+     */
+    public function isValidCategoryId($category_id, $include_deleted = false) {
+        if ($include_deleted) {
+            $where = '';
+        } else {
+            $where = 'del_flg = 0';
+        }
+        if (
+            SC_Utils_Ex::sfIsInt($category_id)
+            && !SC_Utils_Ex::sfIsZeroFilling($category_id)
+            && SC_Helper_DB_Ex::sfIsRecord('dtb_category','category_id', array($category_id), $where)
+        ) {
+            return true;
+        }
+        return false;
+    }
 }

branches/version-2_13-dev/data/class/helper/SC_Helper_DB.php

@@ -524 +524 @@
         $category_id = (int) $category_id;
         $product_id = (int) $product_id;
-        if (SC_Utils_Ex::sfIsInt($category_id) && $category_id != 0 && SC_Helper_DB_Ex::sfIsRecord('dtb_category','category_id', array($category_id))) {
+        $objCategory = new SC_Helper_Category_Ex();
+        if ($objCategory->isValidCategoryId($category_id, $closed)) {
             $category_id = array($category_id);
         } else {