Changeset 21935 for branches/version-2_12-dev/data/class/helper

Timestamp:

2012/06/21 15:02:41 (14 years ago)

Author:

pineray

Message:

#1859
foreach でキーしか使わない場合に array_keys で配列を作ってから渡す方法だと、
メモリを倍ほど消費することがわかったので、見苦しいけれど不要なバリューを生成する方向に.
F*in' PHP!

Location:

branches/version-2_12-dev/data/class/helper

Files:

• SC_Helper_CSV.php (modified) (1 diff)
• SC_Helper_Mail.php (modified) (1 diff)
• SC_Helper_Mobile.php (modified) (1 diff)
• SC_Helper_PageLayout.php (modified) (2 diffs)
• SC_Helper_Purchase.php (modified) (3 diffs)

branches/version-2_12-dev/data/class/helper/SC_Helper_CSV.php

@@ -277 +277 @@
         }
 
-        foreach (array_keys($fields) as $key) {
+        foreach ($fields as $key => $value) {
             $field =& $fields[$key];
 

branches/version-2_12-dev/data/class/helper/SC_Helper_Mail.php

@@ -137 +137 @@
         $objQuery->setOrder('shipping_id');
         $arrRet = $objQuery->select('*', 'dtb_shipping', 'order_id = ?', array($order_id));
-        foreach (array_keys($arrRet) as $key) {
+        foreach ($arrRet as $key => $value) {
             $objQuery->setOrder('shipping_id');
             $arrItems = $objQuery->select('*', 'dtb_shipment_item', 'order_id = ? AND shipping_id = ?',

branches/version-2_12-dev/data/class/helper/SC_Helper_Mobile.php

@@ -96 +96 @@
     function lfMobileConvertInputValue(&$value) {
         if (is_array($value)) {
-            foreach (array_keys($value) as $key) {
+            foreach ($value as $key => $val) {
                 $this->lfMobileConvertInputValue($value[$key]);
             }

branches/version-2_12-dev/data/class/helper/SC_Helper_PageLayout.php

@@ -75 +75 @@
         $arrBlocs = $objPlugin->getEnableBlocs($arrBlocs);
         // php_path, tpl_path が存在するものを, 各ターゲットに配置
-        foreach (array_keys($arrTarget) as $target_id) {
+        foreach ($arrTarget as $target_id => $value) {
             foreach ($arrBlocs as $arrBloc) {
                 if ($arrBloc['target_id'] != $target_id) {
@@ -324 +324 @@
      */
     function setBlocPathTo($device_type_id = DEVICE_TYPE_PC, &$arrBlocs = array()) {
-        foreach (array_keys($arrBlocs) as $key) {
+        foreach ($arrBlocs as $key => $value) {
             $arrBloc =& $arrBlocs[$key];
             $arrBloc['php_path'] = SC_Utils_Ex::isBlank($arrBloc['php_path']) ? '' : HTML_REALDIR . $arrBloc['php_path'];

branches/version-2_12-dev/data/class/helper/SC_Helper_Purchase.php

@@ -317 +317 @@
     function clearShipmentItemTemp($shipping_id = null) {
         if (is_null($shipping_id)) {
-            foreach (array_keys($_SESSION['shipping']) as $key) {
+            foreach ($_SESSION['shipping'] as $key => $value) {
                 $this->clearShipmentItemTemp($key);
             }
@@ -1036 +1036 @@
      */
     function setDownloadableFlgTo(&$arrOrderDetail) {
-        foreach (array_keys($arrOrderDetail) as $key) {
+        foreach ($arrOrderDetail as $key => $value) {
             // 販売価格が 0 円
             if ($arrOrderDetail[$key]['price'] == '0') {
@@ -1072 +1072 @@
 
         if ($has_items) {
-            foreach (array_keys($arrResults) as $shipping_id) {
+            foreach ($arrResults as $shipping_id => $value) {
                 $arrResults[$shipping_id]['shipment_item']
                         =& $this->getShipmentItems($order_id, $shipping_id);