Changeset 20726

Timestamp:

2011/03/18 21:42:22 (12 years ago)

Author:

shutta

Message:

refs #1173
カテゴリーカウント処理が重かったのを修正。
sfGetParents*、sfGetChildren* 絡みの処理効率を改善。

File:

• branches/version-2_5-dev/data/class/helper/SC_Helper_DB.php (modified) (7 diffs)

branches/version-2_5-dev/data/class/helper/SC_Helper_DB.php

@@ -744 +744 @@
             $arrTgtCategory_id[] = $parent_category_id;
             $arrParentID = $this->sfGetParents('dtb_category', 'parent_category_id', 'category_id', $parent_category_id);
-            foreach($arrParentID as $pid) {
-                $arrTgtCategory_id[] = $pid;
-            }
+            $arrTgtCategory_id = array_merge($arrTgtCategory_id, $arrParentID);
         }
 
@@ -815 +813 @@
      */
     function sfGetChildrenArray($table, $pid_name, $id_name, $id) {
-        $objQuery =& SC_Query_Ex::getSingletonInstance();
-        $col = $pid_name . "," . $id_name;
-        $arrData = $objQuery->select($col, $table);
-
-        $arrPID = array();
-        $arrPID[] = $id;
         $arrChildren = array();
-        $arrChildren[] = $id;
-
-        $arrRet = SC_Helper_DB_Ex::sfGetChildrenArraySub($arrData, $pid_name, $id_name, $arrPID);
+        $arrRet = array($id);
 
         while(count($arrRet) > 0) {
             $arrChildren = array_merge($arrChildren, $arrRet);
-            $arrRet = SC_Helper_DB_Ex::sfGetChildrenArraySub($arrData, $pid_name, $id_name, $arrRet);
+            $arrRet = SC_Helper_DB_Ex::sfGetChildrenArraySub($table, $pid_name, $id_name, $arrRet);
         }
 
@@ -843 +833 @@
      * @return array 子IDの配列
      */
-    function sfGetChildrenArraySub($arrData, $pid_name, $id_name, $arrPID) {
+    function sfGetChildrenArraySub($table, $pid_name, $id_name, $arrPID) {
+        $objQuery =& SC_Query_Ex::getSingletonInstance();
+
+        $where = "$pid_name IN (" . implode(',', array_fill(0, count($arrPID), '?')) . ")";
+
+        $ret = $objQuery->select($id_name, $table, $where, $arrPID);
+
         $arrChildren = array();
-        $max = count($arrData);
-
-        for($i = 0; $i < $max; $i++) {
-            foreach($arrPID as $val) {
-                if($arrData[$i][$pid_name] == $val) {
-                    $arrChildren[] = $arrData[$i][$id_name];
-                }
-            }
-        }
+        foreach ($ret as $val) {
+            $arrChildren[] = $val[$id_name];
+        }
+
         return $arrChildren;
     }
@@ -869 +860 @@
     function sfGetParents($table, $pid_name, $id_name, $id) {
         $arrRet = SC_Helper_DB_Ex::sfGetParentsArray($table, $pid_name, $id_name, $id);
-        // 配列の先頭1つを削除する。
-        array_shift($arrRet);
         return $arrRet;
     }
@@ -884 +873 @@
      */
     function sfGetParentsArray($table, $pid_name, $id_name, $id) {
-        $objQuery =& SC_Query_Ex::getSingletonInstance();
-        $col = $pid_name . "," . $id_name;
-        $arrData = $objQuery->select($col, $table);
-
         $arrParents = array();
-        $arrParents[] = $id;
-        $child = $id;
-
-        $ret = SC_Helper_DB_Ex::sfGetParentsArraySub($arrData, $pid_name, $id_name, $child);
-
-        while($ret != "") {
+        $ret = $id;
+
+        while($ret != "0") {
             $arrParents[] = $ret;
-            $ret = SC_Helper_DB_Ex::sfGetParentsArraySub($arrData, $pid_name, $id_name, $ret);
-        }
-
-        $arrParents = array_reverse($arrParents);
+            $ret = SC_Helper_DB_Ex::sfGetParentsArraySub($table, $pid_name, $id_name, $ret);
+        }
 
         return $arrParents;
@@ -905 +885 @@
 
     /* 子ID所属する親IDを取得する */
-    function sfGetParentsArraySub($arrData, $pid_name, $id_name, $child) {
-        $max = count($arrData);
-        $parent = "";
-        for($i = 0; $i < $max; $i++) {
-            if($arrData[$i][$id_name] == $child) {
-                $parent = $arrData[$i][$pid_name];
-                break;
-            }
-        }
+    function sfGetParentsArraySub($table, $pid_name, $id_name, $child) {
+        $objQuery =& SC_Query_Ex::getSingletonInstance();
+        $parent = $objQuery->get($pid_name, $table, "$id_name = ?", $child);
         return $parent;
     }
@@ -926 +900 @@
         // 子カテゴリIDの取得
         $arrRet = SC_Helper_DB_Ex::sfGetChildrenArray("dtb_category", "parent_category_id", "category_id", $category_id);
-        $tmp_where = "";
-        foreach ($arrRet as $val) {
-            if($tmp_where == "") {
-                $tmp_where.= "category_id IN ( ?";
-            } else {
-                $tmp_where.= ",? ";
-            }
-            $arrval[] = $val;
-        }
-        $tmp_where.= " ) ";
-        return array($tmp_where, $arrval);
+
+        $where = "category_id IN (" . implode(',', array_fill(0, count($arrRet), '?')) . ")";
+
+        return array($where, $arrRet);
     }