Changeset 20158 for branches/version-2_5-dev/data/class

Timestamp:

2011/02/12 19:44:40 (15 years ago)

Author:

kimoto

Message:

LC_Page_Mypage_DownLoad リファクタリング

• sendResponseが特殊すぎる為そこは触っていません

File:

• branches/version-2_5-dev/data/class/pages/mypage/LC_Page_Mypage_DownLoad.php (modified) (3 diffs)

branches/version-2_5-dev/data/class/pages/mypage/LC_Page_Mypage_DownLoad.php

@@ -76 +76 @@
 
         // パラメータチェック
-        $this->objFormParam = new SC_FormParam();
-        $this->lfInitParam();
+        $objFormParam = new SC_FormParam();
+        $this->lfInitParam($objFormParam);
         // GET、SESSION['customer']値の取得
-        $this->objFormParam->setParam($_SESSION['customer']);
-        $this->objFormParam->setParam($_GET);
-        $this->arrErr = $this->lfCheckError();
+        $objFormParam->setParam($_SESSION['customer']);
+        $objFormParam->setParam($_GET);
+        $this->arrErr = $this->lfCheckError($objFormParam);
         if (count($this->arrErr)!=0){
             SC_Utils_Ex::sfDispSiteError(DOWNFILE_NOT_FOUND,"",true);
@@ -89 +89 @@
     /**
      * Page のResponse.
+     *
+     * todo たいした処理でないのに異常に処理が重い
      * @return void
      */
@@ -191 +193 @@
 
     /* パラメータ情報の初期化 */
-    function lfInitParam() {
-        $this->objFormParam->addParam("customer_id", "customer_id", INT_LEN, "n", array("EXIST_CHECK","NUM_CHECK"));
-        $this->objFormParam->addParam("order_id", "order_id", INT_LEN, "n", array("EXIST_CHECK", "NUM_CHECK"));
-        $this->objFormParam->addParam("product_id", "product_id", INT_LEN, "n", array("EXIST_CHECK","NUM_CHECK"));
-        $this->objFormParam->addParam("product_class_id", "product_class_id", INT_LEN, "n", array("EXIST_CHECK","NUM_CHECK"));
+    function lfInitParam(&$objFormParam) {
+        $objFormParam->addParam("customer_id", "customer_id", INT_LEN, "n", array("EXIST_CHECK","NUM_CHECK"));
+        $objFormParam->addParam("order_id", "order_id", INT_LEN, "n", array("EXIST_CHECK", "NUM_CHECK"));
+        $objFormParam->addParam("product_id", "product_id", INT_LEN, "n", array("EXIST_CHECK","NUM_CHECK"));
+        $objFormParam->addParam("product_class_id", "product_class_id", INT_LEN, "n", array("EXIST_CHECK","NUM_CHECK"));
     }
 
     /* 入力内容のチェック */
-    function lfCheckError() {
-        // 入力データを渡す。
-        $arrRet = $this->objFormParam->getHashArray();
-        $objErr = new SC_CheckError($arrRet);
-        $objErr->arrErr = $this->objFormParam->checkError();
+    function lfCheckError(&$objFormParam) {
+        $objErr = new SC_CheckError($objFormParam->getHashArray());
+        $objErr->arrErr = $objFormParam->checkError();
         return $objErr->arrErr;
     }