Ticket #1983 (new 改善提案)

Opened 8 years ago

Last modified 6 years ago

LC_Page_Admin_Total のセッションの扱いが無駄に危険

Reported by: Seasoft Owned by: somebody
Priority: Milestone: EC-CUBE2.13.x
Component: 管理画面 Version: 2.12.2
Keywords: Cc:
修正済み: no

Description (last modified by kim) (diff)

$_SESSION           = $this->lfSaveDateSession($_SESSION, $this->arrHidden);
  • セッション変数を丸ごと書き換えている
  • セッション変数はスーパーグローバル変数なので渡す必要は無い。($_SESSION['total']を渡すならば分からなくもないが・・・)
  • $_SESSION['total'] はあまりにも安直な命名と感じる。せめて、ページクラス名に相当する程度の冗長さがあって良いように感じる。

関連チケット: #2087

Change History

comment:1 Changed 8 years ago by Seasoft

  • Milestone changed from EC-CUBE2.12.x(多言語対応) to EC-CUBE 2.12.3

comment:2 Changed 8 years ago by kim

  • Milestone changed from EC-CUBE2.12.3 to EC-CUBE2.12.4

comment:3 Changed 8 years ago by undertree

  • Owner changed from somebody to undertree
  • Status changed from new to assigned

関連チケット(?): #2087

comment:4 Changed 7 years ago by undertree

  • Status changed from assigned to new

comment:5 Changed 7 years ago by h_yoshimoto

  • Milestone changed from EC-CUBE2.13.0 to EC-CUBE 2.13.1

comment:6 Changed 7 years ago by m_uehara

  • Milestone changed from EC-CUBE 2.13.1 to EC-CUBE 2.13.2

comment:7 Changed 6 years ago by h_yoshimoto

  • Milestone changed from EC-CUBE2.13.2 to EC-CUBE2.13.3

comment:8 Changed 6 years ago by kim

  • Description modified (diff)
  • Milestone changed from EC-CUBE2.13.3 to EC-CUBE2.13.4

次期バージョンに移します。

comment:9 Changed 6 years ago by kim

  • Owner changed from undertree to somebody

担当者をいったん開放します。

Note: See TracTickets for help on using tickets.