Changeset 23459 for branches/version-2_13-dev/data/class/SC_Product.php

Timestamp:

2014/05/29 14:40:57 (10 years ago)

Author:

pineray

Message:

#2515 無駄な処理を改善する for 2.13.3

カテゴリーID取得部分の処理を整理.

File:

• branches/version-2_13-dev/data/class/SC_Product.php (modified) (2 diffs)

branches/version-2_13-dev/data/class/SC_Product.php

@@ -696 +696 @@
      */
     public function getCategoryIds($product_id, $include_hidden = false) {
-        if ($include_hidden) {
-            $where = '';
-        } else {
-            $where = 'status = 1';
-        }
-
-        if (SC_Utils_Ex::sfIsInt($product_id) && $product_id != 0 && SC_Helper_DB_Ex::sfIsRecord('dtb_products','product_id', array($product_id), $where)) {
+        if ($this->isValidProductId($product_id, $include_hidden)) {
             $objQuery =& SC_Query_Ex::getSingletonInstance();
             $category_id = $objQuery->getCol('category_id', 'dtb_product_categories', 'product_id = ?', array($product_id));
@@ -712 +706 @@
         return $category_id;
     }
+
+    /**
+     * 有効な商品IDかチェックする.
+     *
+     * @param int $product_id
+     * @param bool $include_hidden
+     * @param bool $include_deleted
+     * @return bool
+     */
+    public function isValidProductId($product_id, $include_hidden = false, $include_deleted = false) {
+        $where = '';
+        if (!$include_hidden) {
+            $where .= ' status = 1';
+        }
+        if (!$include_deleted) {
+            $where .= ' del_flg = 0';
+        }
+        if (
+            SC_Utils_Ex::sfIsInt($product_id)
+            && !SC_Utils_Ex::sfIsZeroFilling($product_id)
+            && SC_Helper_DB_Ex::sfIsRecord('dtb_products','product_id', array($product_id), $where)
+        ) {
+            return true;
+        }
+        return false;
+    }
 }