Changeset 22946 for branches/version-2_13-dev/data/class/pages/products/LC_Page_Products_Detail.php

Timestamp:

2013/07/07 16:48:59 (8 years ago)

Author:

kimoto

Message:

#2043 typo修正・ソース整形・ソースコメントの改善 for 2.13.0
不要な変数を削除
ソースの整形

File:

• branches/version-2_13-dev/data/class/pages/products/LC_Page_Products_Detail.php (modified) (12 diffs)

branches/version-2_13-dev/data/class/pages/products/LC_Page_Products_Detail.php

@@ -112 +112 @@
 
         // プロダクトIDの正当性チェック
-        $product_id = $this->lfCheckProductId($this->objFormParam->getValue('admin'),$this->objFormParam->getValue('product_id'));
+        $product_id = $this->lfCheckProductId($this->objFormParam->getValue('admin'), $this->objFormParam->getValue('product_id'));
         $this->mode = $this->getMode();
 
@@ -149 +149 @@
         // モバイル用 規格選択セレクトボックスの作成
         if (SC_Display_Ex::detectDevice() == DEVICE_TYPE_MOBILE) {
-            $this->lfMakeSelectMobile($this, $product_id,$this->objFormParam->getValue('classcategory_id1'));
+            $this->lfMakeSelectMobile($this, $product_id, $this->objFormParam->getValue('classcategory_id1'));
         }
 
@@ -224 +224 @@
             = SC_Utils_Ex::sfNoImageMain($this->arrProduct['main_image']);
 
-        $this->subImageFlag = $this->lfSetFile($this->objUpFile,$this->arrProduct,$this->arrFile);
+        $this->subImageFlag = $this->lfSetFile($this->objUpFile, $this->arrProduct, $this->arrFile);
         //レビュー情報の取得
         $this->arrReview = $this->lfGetReviewData($product_id);
@@ -240 +240 @@
 
     /* プロダクトIDの正当性チェック */
-    function lfCheckProductId($admin_mode,$product_id)
+    function lfCheckProductId($admin_mode, $product_id)
     {
         // 管理機能からの確認の場合は、非公開の商品も表示する。
@@ -283 +283 @@
 
     /* 規格選択セレクトボックスの作成(モバイル) */
-    function lfMakeSelectMobile(&$objPage, $product_id,$request_classcategory_id1)
+    function lfMakeSelectMobile(&$objPage, $product_id, $request_classcategory_id1)
     {
         $classcat_find1 = false;
@@ -380 +380 @@
         $arrRecommendData = $objQuery->select('recommend_product_id, comment', 'dtb_recommend_products as t1 left join dtb_products as t2 on t1.recommend_product_id = t2.product_id', 't1.product_id = ? and t2.del_flg = 0 and t2.status = 1', array($product_id));
 
-        $arrRecommendProductId = array();
+        $recommendProductIds = array();
         foreach ($arrRecommendData as $recommend) {
-            $arrRecommendProductId[] = $recommend['recommend_product_id'];
+            $recommendProductIds[] = $recommend['recommend_product_id'];
         }
 
         $objQuery =& SC_Query_Ex::getSingletonInstance();
-        $arrProducts = $objProduct->getListByProductIds($objQuery, $arrRecommendProductId);
-
-        $arrRecommend = array();
+        $arrProducts = $objProduct->getListByProductIds($objQuery, $recommendProductIds);
+
         foreach ($arrRecommendData as $key => $arrRow) {
             $arrRecommendData[$key] = array_merge($arrRow, $arrProducts[$arrRow['recommend_product_id']]);
@@ -397 +396 @@
 
     /* 入力内容のチェック */
-    function lfCheckError($mode,&$objFormParam,$tpl_classcat_find1 = null ,$tpl_classcat_find2 = null)
+    function lfCheckError($mode, &$objFormParam, $tpl_classcat_find1 = null , $tpl_classcat_find2 = null)
     {
         switch ($mode) {
@@ -429 +428 @@
 
     //商品ごとのレビュー情報を取得する
-    function lfGetReviewData($id)
+    function lfGetReviewData($product_id)
     {
         $objQuery =& SC_Query_Ex::getSingletonInstance();
@@ -438 +437 @@
         $objQuery->setOrder('create_date DESC');
         $objQuery->setLimit(REVIEW_REGIST_MAX);
-        $arrWhereVal = array($id);
+        $arrWhereVal = array($product_id);
         $arrReview = $objQuery->select($col, $from, $where, $arrWhereVal);
 
@@ -448 +447 @@
      * @return $subImageFlag
      */
-    function lfSetFile($objUpFile,$arrProduct,&$arrFile)
+    function lfSetFile($objUpFile, $arrProduct, &$arrFile)
     {
         // DBからのデータを引き継ぐ
@@ -470 +469 @@
      * @return void
      */
-    function lfRegistFavoriteProduct($favorite_product_id,$customer_id)
+    function lfRegistFavoriteProduct($favorite_product_id, $customer_id)
     {
         // ログイン中のユーザが商品をお気に入りにいれる処理
@@ -604 +603 @@
     function doMobileSelect2()
     {
-        $this->arrErr = $this->lfCheckError($this->mode,$this->objFormParam,$this->tpl_classcat_find1,$this->tpl_classcat_find2);
+        $this->arrErr = $this->lfCheckError($this->mode, $this->objFormParam, $this->tpl_classcat_find1, $this->tpl_classcat_find2);
 
         // 規格1が設定されていて、エラーを検出した場合