Changeset 21935 for branches/version-2_12-dev/data/class/pages/admin

Timestamp:

2012/06/21 15:02:41 (12 years ago)

Author:

pineray

Message:

#1859
foreach でキーしか使わない場合に array_keys で配列を作ってから渡す方法だと、
メモリを倍ほど消費することがわかったので、見苦しいけれど不要なバリューを生成する方向に.
F*in' PHP!

Location:

branches/version-2_12-dev/data/class/pages/admin

Files:

• order/LC_Page_Admin_Order_Edit.php (modified) (1 diff)
• products/LC_Page_Admin_Products_Product.php (modified) (1 diff)
• system/LC_Page_Admin_System_Bkup.php (modified) (1 diff)
• total/LC_Page_Admin_Total.php (modified) (5 diffs)

branches/version-2_12-dev/data/class/pages/admin/order/LC_Page_Admin_Order_Edit.php

@@ -784 +784 @@
         $exists = false;
         $arrExistsProductClassIds = $objFormParam->getValue('product_class_id');
-        foreach (array_keys($arrExistsProductClassIds) as $key) {
+        foreach ($arrExistsProductClassIds as $key => $value) {
             $exists_product_class_id = $arrExistsProductClassIds[$key];
             if ($exists_product_class_id == $product_class_id) {

branches/version-2_12-dev/data/class/pages/admin/products/LC_Page_Admin_Products_Product.php

@@ -497 +497 @@
         $select_recommend_id = $arrForm['recommend_id' . $select_recommend_no];
 
-        foreach (array_keys($arrForm) as $key) {
+        foreach ($arrForm as $key => $value) {
             if (preg_match('/^recommend_id/', $key)) {
                 if ($select_recommend_no == preg_replace('/^recommend_id/', '', $key)) {

branches/version-2_12-dev/data/class/pages/admin/system/LC_Page_Admin_System_Bkup.php

@@ -450 +450 @@
                 }
                 unset($row);
-                foreach (array_keys($ret) as $key) {
+                foreach ($ret as $key => $value) {
                     if ($ret[$key]['bkup_name'] == $bkup_name) {
                         $row =& $ret[$key];

branches/version-2_12-dev/data/class/pages/admin/total/LC_Page_Admin_Total.php

@@ -416 +416 @@
             $objGraphBar = new SC_Graph_Bar();
 
-            foreach (array_keys($arrList) as $val) {
-                $arrKey[] = mb_ereg_replace('～', '-', $val);
+            foreach ($arrList as $key => $value) {
+                $arrKey[] = mb_ereg_replace('～', '-', $key);
             }
 
@@ -527 +527 @@
         $arrTotalResults = $objQuery->select($col, $from, $where, $arrWhereVal);
 
-        foreach (array_keys($arrTotalResults) as $key) {
+        foreach ($arrTotalResults as $key => $value) {
             $arrResult =& $arrTotalResults[$key];
             $member_key = $arrResult['order_sex'];
@@ -600 +600 @@
         $arrTotalResults = $objQuery->select($col, $from, $where, $arrWhereVal);
 
-        foreach (array_keys($arrTotalResults) as $key) {
+        foreach ($arrTotalResults as $key => $value) {
             $arrResult =& $arrTotalResults[$key];
             $job_key = $arrResult['job'];
@@ -637 +637 @@
         $arrTotalResults = $objQuery->select($col, $from, $where, $arrWhereVal);
 
-        foreach (array_keys($arrTotalResults) as $key) {
+        foreach ($arrTotalResults as $key => $value) {
             $arrResult =& $arrTotalResults[$key];
             $age_key = $arrResult['age'];
@@ -783 +783 @@
             // 合計の計算
             foreach ($arrResults as $arrResult) {
-                foreach (array_keys($arrResult) as $value) {
-                    $arrTotal[$value] += $arrResult[$value];
+                foreach ($arrResult as $key => $value) {
+                    $arrTotal[$key] += $arrResult[$key];
                 }
             }