Changeset 21376 for branches/version-2_11-dev/data/class/helper

Timestamp:

2011/12/26 17:11:08 (15 years ago)

Author:

Seasoft

Message:

#1582 (SC_Query 一致レコードの有無を返す機能を追加 (パフォーマンス改善))
#1526 (typo修正・ソース整形・ソースコメントの改善)
#1449 (不要な関数・処理の整理)

Location:

branches/version-2_11-dev/data/class/helper

Files:

• SC_Helper_Customer.php (modified) (1 diff)
• SC_Helper_DB.php (modified) (5 diffs)
• SC_Helper_Mobile.php (modified) (1 diff)
• SC_Helper_PageLayout.php (modified) (1 diff)
• SC_Helper_Purchase.php (modified) (1 diff)
• SC_Helper_Session.php (modified) (1 diff)

branches/version-2_11-dev/data/class/helper/SC_Helper_Customer.php

@@ -276 +276 @@
      */
     function sfGetUniqSecretKey() {
-        $objQuery   =& SC_Query_Ex::getSingletonInstance();
-        $count      = 1;
-        while ($count != 0) {
+        $objQuery =& SC_Query_Ex::getSingletonInstance();
+
+        do {
             $uniqid = SC_Utils_Ex::sfGetUniqRandomId('r');
-            $count  = $objQuery->count("dtb_customer", "secret_key = ?", array($uniqid));
-        }
+            $exists = $objQuery->exists("dtb_customer", "secret_key = ?", array($uniqid));
+        } while ($exists);
         return $uniqid;
     }

branches/version-2_11-dev/data/class/helper/SC_Helper_DB.php

@@ -99 +99 @@
      * @param string $where データを検索する WHERE 句
      * @param string $dsn データソース名
-     * @param string $sql データの追加を行う場合の SQL文
-     * @param bool $add データの追加も行う場合 true
+     * @param string $sql @deprecated データの追加を行う場合の SQL文
+     * @param bool $add @deprecated データの追加も行う場合 true
      * @return bool データが存在する場合 true, データの追加に成功した場合 true,
      *               $add == false で, データが存在しない場合 false
@@ -109 +109 @@
 
         $objQuery =& SC_Query_Ex::getSingletonInstance();
-        $count = $objQuery->count($table_name, $where, $arrval);
-
-        if($count > 0) {
-            $ret = true;
-        } else {
-            $ret = false;
-        }
+        $exists = $objQuery->exists($table_name, $where, $arrval);
+
         // データを追加する
-        if(!$ret && $add) {
+        if(!$exists && $add) {
             $objQuery->exec($sql);
         }
@@ -158 +153 @@
      *
      * @return int
+     * @deprecated
      */
     function sfGetBasisCount() {
@@ -163 +159 @@
 
         return $objQuery->count("dtb_baseinfo");
+    }
+
+    /**
+     * 基本情報の登録有無を取得する
+     *
+     * @return boolean 有無
+     */
+    function sfGetBasisExists() {
+        $objQuery =& SC_Query_Ex::getSingletonInstance();
+
+        return $objQuery->exists('dtb_baseinfo');
     }
 
@@ -1431 +1438 @@
         $objQuery =& SC_Query_Ex::getSingletonInstance();
         $where = 'product_id = ? AND del_flg = 0 AND class_combination_id IS NOT NULL';
-        $count = $objQuery->count('dtb_products_class', $where, array($product_id));
-
-        return $count >= 1;
+        $exists = $objQuery->exists('dtb_products_class', $where, array($product_id));
+
+        return $exists;
     }
 }

branches/version-2_11-dev/data/class/helper/SC_Helper_Mobile.php

@@ -384 +384 @@
             $arrValues['kara_mail_id'] = $objQuery->nextVal('dtb_mobile_kara_mail_kara_mail_id');
             $objQuery->insert('dtb_mobile_kara_mail', $arrValues);
-            $count = $objQuery->count('dtb_mobile_kara_mail', 'token = ?', array($token));
-
-            if ($count == 1) {
+            $exists = $objQuery->exists('dtb_mobile_kara_mail', 'token = ?', array($token));
+
+            if ($exists) {
                 break;
             }

branches/version-2_11-dev/data/class/helper/SC_Helper_PageLayout.php

@@ -210 +210 @@
          * PHP ファイルは, 複数のデバイスで共有するため, device_type_id を条件に入れない
          */
-        $count = $objQuery->count('dtb_pagelayout', 'filename = ?', array($filename));
-
-        if ($count == 0) {
+        $exists = $objQuery->exists('dtb_pagelayout', 'filename = ?', array($filename));
+
+        if (!$exists) {
             // phpファイルの削除
             $del_php = HTML_REALDIR . $filename . '.php';

branches/version-2_11-dev/data/class/helper/SC_Helper_Purchase.php

@@ -833 +833 @@
         $arrValues = $objQuery->extractOnlyColsOf($table, $arrParams);
 
-        $exists = $objQuery->count($table, $where, array($order_id));
-        if ($exists > 0) {
+        $exists = $objQuery->exists($table, $where, array($order_id));
+        if ($exists) {
 
             $this->sfUpdateOrderStatus($order_id, $arrValues['status'],

branches/version-2_11-dev/data/class/helper/SC_Helper_Session.php

@@ -84 +84 @@
      {
          $objQuery = new SC_Query_Ex();
-         $count = $objQuery->count("dtb_session", "sess_id = ?", array($id));
+         $exists = $objQuery->exists("dtb_session", "sess_id = ?", array($id));
+var_dump($id, $exists);exit;
          $sqlval = array();
-         if($count > 0) {
+         if ($exists) {
              // レコード更新
              $sqlval['sess_data'] = $sess_data;