Changeset 21256 for branches/version-2_11-dev/data/class/pages/products/LC_Page_Products_Detail.php

Timestamp:

2011/09/25 13:15:51 (13 years ago)

Author:

Seasoft

Message:

#1484 (SC_Product#lists の第2引数($arrVal)が実質的に無効)
#1449 (不要な関数・処理の整理)
#1421 (Fix typo.)
#1463 (コーディング規則に従っていない)

File:

• branches/version-2_11-dev/data/class/pages/products/LC_Page_Products_Detail.php (modified) (3 diffs)

branches/version-2_11-dev/data/class/pages/products/LC_Page_Products_Detail.php

@@ -409 +409 @@
     /* 登録済み関連商品の読み込み */
     function lfPreGetRecommendProducts($product_id) {
-        $arrRecommend = array();
+        $objProduct = new SC_Product_Ex();
         $objQuery =& SC_Query_Ex::getSingletonInstance();
+
         $objQuery->setOrder("rank DESC");
         $arrRecommendData = $objQuery->select("recommend_product_id, comment", "dtb_recommend_products", "product_id = ?", array($product_id));
@@ -420 +421 @@
         }
 
-        $objProduct = new SC_Product_Ex();
-
-        $where = "";
-        if (!empty($arrRecommendProductId)) {
-            $where = 'product_id IN (' . implode(',', $arrRecommendProductId) . ')';
-        } else {
-            return $arrRecommend;
-        }
         $objQuery =& SC_Query_Ex::getSingletonInstance();
-        $objQuery->setWhere($where);
-        $arrProducts = $objProduct->lists($objQuery, $arrRecommendProductId);
+        $arrProducts = $objProduct->getListByProductIds($objQuery, $arrRecommendProductId);
 
         //取得している並び順で並び替え
@@ -438 +430 @@
             $arrProducts2[ $item['product_id'] ] = $item;
         }
-        $arrProducts = array();
+
+        $arrRecommend = array();
         foreach($arrRecommendProductId as $product_id) {
             $arrProducts2[$product_id]['comment'] = $arrRecommendData[$product_id];