Changeset 20203 for branches/version-2_5-dev/data/class/pages/admin/mail

Timestamp:

2011/02/19 18:38:11 (13 years ago)

Author:

fukuda

Message:

・SC_Helper_Mail::sfGetMailTemplateの引数を簡潔に
・SC_Utils_Ex::sfCheckNumLength()をSC_Utils_Ex::sfIsInt()に統合
・ガイドラインに合わない $this->list_data を修正

Location:

branches/version-2_5-dev/data/class/pages/admin/mail

Files:

• LC_Page_Admin_Mail.php (modified) (2 diffs)
• LC_Page_Admin_Mail_History.php (modified) (1 diff)
• LC_Page_Admin_Mail_Preview.php (modified) (2 diffs)
• LC_Page_Admin_Mail_Template.php (modified) (3 diffs)
• LC_Page_Admin_Mail_TemplateInput.php (modified) (1 diff)

branches/version-2_5-dev/data/class/pages/admin/mail/LC_Page_Admin_Mail.php

@@ -173 +173 @@
              query:配信履歴「確認」
             */
-            if (SC_Utils_Ex::sfCheckNumLength($_GET["send_id"])) {
+            if (SC_Utils_Ex::sfIsInt($_GET["send_id"])) {
                 // 送信履歴より、送信条件確認画面
                 $sql = "SELECT search_data FROM dtb_send_history WHERE send_id = ?";
@@ -675 +675 @@
     function getTemplateData(&$objQuery, $id){
 
-        if ( SC_Utils_Ex::sfCheckNumLength($id) ){
+        if ( SC_Utils_Ex::sfIsInt($id) ){
             $sql = "SELECT * FROM dtb_mailmaga_template WHERE template_id = ? ORDER BY template_id DESC";
             $result = $objQuery->getAll( $sql, array($id) );

branches/version-2_5-dev/data/class/pages/admin/mail/LC_Page_Admin_Mail_History.php

@@ -82 +82 @@
         case 'delete':
             // 削除時
-            if (SC_Utils_Ex::sfCheckNumLength($_GET['send_id'])) {
+            if (SC_Utils_Ex::sfIsInt($_GET['send_id'])) {
                 $sql = "UPDATE dtb_send_history SET del_flg = 1 WHERE send_id = ?";
                 $objQuery->query($sql, array($_GET['send_id']) );

branches/version-2_5-dev/data/class/pages/admin/mail/LC_Page_Admin_Mail_Preview.php

@@ -70 +70 @@
         SC_Utils_Ex::sfIsSuccess($objSess);
 
-        if (!isset($_POST['body'])) $_POST['body'] = "";
-        if (!isset($_REQUEST['method'])) $_REQUEST['method'] = "";
-        if (!isset($_REQUEST['id'])) $_REQUEST['id'] = "";
-        if (!isset($_GET['send_id'])) $_GET['send_id'] = "";
-
-        if ( $_POST['body'] ){
-            $this->body = $_POST['body'];
-
-            // HTMLメールテンプレートのプレビュー
-        } elseif ($_REQUEST["method"] == "template"
-                  && SC_Utils_Ex::sfCheckNumLength($_REQUEST['id'])) {
-
-            $sql = "SELECT * FROM dtb_mailmaga_template WHERE template_id = ?";
-            $result = $objQuery->getAll($sql, array($_REQUEST["id"]));
-            $this->list_data = $result[0];
-
-            // メイン商品の情報取得
-            // FIXME SC_Product クラスを使用した実装
-            $sql = "SELECT name, main_image, point_rate, deliv_fee, price01_min, price01_max, price02_min, price02_max FROM vw_products_allclass AS allcls WHERE product_id = ?";
-            $main = $objQuery->getAll($sql, array($this->list_data["main_product_id"]));
-            $this->list_data["main"] = $main[0];
-
-            // サブ商品の情報取得
-            // FIXME SC_Product クラスを使用した実装
-            $sql = "SELECT product_id, name, main_list_image, price01_min, price01_max, price02_min, price02_max FROM vw_products_allclass WHERE product_id = ?";
-            $k = 0;
-            $l = 0;
-            for ($i = 1; $i <= 12; $i ++) {
-                if ($l == 4) {
-                    $l = 0;
-                    $k ++;
-                }
-                $result = "";
-                $j = sprintf("%02d", $i);
-                if ($i > 0 && $i < 5 ) $k = 0;
-                if ($i > 4 && $i < 9 ) $k = 1;
-                if ($i > 8 && $i < 13 ) $k = 2;
-
-                if (is_numeric($this->list_data["sub_product_id" .$j])) {
-                    $result = $objQuery->getAll($sql, array($this->list_data["sub_product_id" .$j]));
-                    $this->list_data["sub"][$k][$l] = $result[0];
-                    $this->list_data["sub"][$k]["data_exists"] = "OK";  //当該段にデータが１つ以上存在するフラグ
-                }
-                $l ++;
-            }
-            $this->tpl_mainpage = 'mail/html_template.tpl';
-
-        } elseif (SC_Utils_Ex::sfCheckNumLength($_GET['send_id'])
-                   || SC_Utils_Ex::sfCheckNumLength($_GET['id'])){
+        if (SC_Utils_Ex::sfIsInt($_GET['send_id'])
+                   || SC_Utils_Ex::sfIsInt($_GET['id'])){
+                       
             if (is_numeric($_GET["send_id"])) {
                 $id = $_GET["send_id"];
@@ -132 +86 @@
                     // テキスト形式の時はタグ文字をエスケープ
                     $this->escape_flag = 1;
-                }
+                }    
                 $this->body = $result[0]["body"];
             }

branches/version-2_5-dev/data/class/pages/admin/mail/LC_Page_Admin_Mail_Template.php

@@ -78 +78 @@
         switch ($this->getMode()) {
         case 'delete':
-            if ( SC_Utils_Ex::sfCheckNumLength($_GET['id'])===true ){
+            if ( SC_Utils_Ex::sfIsInt($_GET['id'])===true ){
                 $this->lfDeleteMailTemplate($_GET['id']);
                 $this->objDisplay->reload(null, true);
@@ -86 +86 @@
             break;
         }
-        $this->list_data = $objMailHelper->sfGetMailTemplate();
+        $this->arrTemplates = $objMailHelper->sfGetMailTemplate();
     }
 
@@ -105 +105 @@
     function lfDeleteMailTemplate($template_id){
         $objQuery =& SC_Query::getSingletonInstance();
-        $sqlval["del_flg"] = "1";
-        $arrValIn[] = $template_id;
-        $objQuery->update("dtb_mailmaga_template", $sqlval, "template_id = ?", $arrValIn);
+        $objQuery->update("dtb_mailmaga_template",
+                          array('del_flg' =>1),
+                          "template_id = ?",
+                          array($template_id));
     }
 

branches/version-2_5-dev/data/class/pages/admin/mail/LC_Page_Admin_Mail_TemplateInput.php

@@ -91 +91 @@
         case 'edit':
             // モードによる処理分岐
-            if ( SC_Utils_Ex::sfCheckNumLength($_GET['template_id'])===true ){
+            if ( SC_Utils_Ex::sfIsInt($_GET['template_id'])===true ){
                 // 編集
                 $sql = "SELECT * FROM dtb_mailmaga_template WHERE template_id = ? AND del_flg = 0";