Changeset 19767 for branches

Timestamp:

2010/12/25 19:02:43 (14 years ago)

Author:

Seasoft

Message:

#838(PHPソース内でのパラメータ「USER_DIR」の利用不徹底)
#494(プラグイン機能)

• 怪しい処理にコメントを追加

Location:

branches/version-2_5-dev

Files:

• data/Smarty/templates/admin/design/header.tpl (modified) (2 diffs)
• data/class/SC_Plugin.php (modified) (3 diffs)
• data/class/pages/products/LC_Page_Products_Detail.php (modified) (1 diff)
• html/install/index.php (modified) (2 diffs)

branches/version-2_5-dev/data/Smarty/templates/admin/design/header.tpl

@@ -34 +34 @@
   <dic id="design-header-preview">
     <!--{if $browser_type == 1 }-->
-      <div style="zoom:0.8"><!--{include file="`$smarty.const.HTML_PATH`user_data/include/preview/header.tpl"}--></div>
+      <div style="zoom:0.8"><!--{include file="`$smarty.const.USER_PATH`include/preview/header.tpl"}--></div>
     <!--{ else }-->
       <span class="attention"><strong>プレビューはIEでのみ表示されます。</strong></span>
@@ -65 +65 @@
   <div id="design-footer-preview">
     <!--{if $browser_type == 1 }-->
-      <div style="zoom:0.8"><!--{include file="`$smarty.const.HTML_PATH`/user_data/include/preview/footer.tpl"}--></div>
+      <div style="zoom:0.8"><!--{include file="`$smarty.const.USER_PATH`/include/preview/footer.tpl"}--></div>
     <!--{ else }-->
       <span class="attention"><strong>プレビューはIEでのみ表示されます。</strong></span>

branches/version-2_5-dev/data/class/SC_Plugin.php

@@ -16 +16 @@
 
     function __construct(){
-        if(!defined(PLUGIN_PATH)){
-            define("PLUGIN_PATH",HTML_PATH."/user_data/plugins/");
+        if (!defined(PLUGIN_PATH)) {
+            define('PLUGIN_PATH', USER_PATH . 'plugins/');
         }
         $this->init();
@@ -57 +57 @@
     function disablePlugin(){
         $objQuery = new SC_Query();
-        $name = preg_replace("/.php/", "", __FILE__);
+        $name = preg_replace("/.php/", "", __FILE__); // XXX 正規表現エスケープ漏れでは?
         $objQuery->update("dtb_plugin", array('enable'=>'0'), "plugin_name = ?", array($name));
     }
@@ -63 +63 @@
     function enablePlugin(){
         $objQuery = new SC_Query();
-        $name = preg_replace("/.php/", "", __FILE__);
+        $name = preg_replace("/.php/", "", __FILE__); // XXX 正規表現エスケープ漏れでは?
         $objQuery->update("dtb_plugin", array('enable'=>'0'), "plugin_name = ?", array($name));
     }

branches/version-2_5-dev/data/class/pages/products/LC_Page_Products_Detail.php

@@ -198 +198 @@
 
                         $this->objDisplay->redirect($this->getLocation(
-                            URL_DIR . 'user_data/gmopg_oneclick_confirm.php', array(), true));
+                            URL_DIR . USER_DIR . 'gmopg_oneclick_confirm.php', array(), true));
                         exit;
                     }

branches/version-2_5-dev/html/install/index.php

@@ -383 +383 @@
     $arrWriteFile = array(
         DATA_PATH . "install.php",
-        HTML_PATH . "user_data",
+        USER_PATH,
         HTML_PATH . "upload",
         DATA_PATH . "cache/",
@@ -505 +505 @@
     $objPage->tpl_mode = 'step0_1';
     // ファイルコピー
-    $objPage->copy_mess = SC_Utils_Ex::sfCopyDir("./user_data/", HTML_PATH . "user_data/", $objPage->copy_mess);
+    $objPage->copy_mess = SC_Utils_Ex::sfCopyDir("./user_data/", USER_PATH, $objPage->copy_mess);
     $objPage->copy_mess = SC_Utils_Ex::sfCopyDir("./save_image/", HTML_PATH . "upload/save_image/", $objPage->copy_mess);
     return $objPage;