Changeset 18685

Timestamp:

2010/06/10 16:44:24 (14 years ago)

Author:

nanasess

bzr:base-revision:

ohkouchi@loop-az.jp-20100610073302-8e245zm42vq398b4

bzr:committer:

Kentaro Ohkouchi <ohkouchi@loop-az.jp>

bzr:file-ids:

data/class/helper/SC_Helper_CSV.php 15535@1e3b908f-19a9-db11-a64c-001125224ba8:branches%2Ffeature-module-update%2Fdata%2Fclass%2Fhelper%2FSC_Helper_CSV.php
data/class/pages/admin/system/LC_Page_Admin_System_Bkup.php 16251@1e3b908f-19a9-db11-a64c-001125224ba8:branches%2Ffeature-module-update%2Fdata%2Fclass%2Fpages%2Fadmin%2Fsystem%2FLC_Page_Admin_System_Bkup.php
data/class/util/SC_Utils.php 15078@1e3b908f-19a9-db11-a64c-001125224ba8:branches%2Ffeature-module-update%2Fdata%2Fclass%2Futil%2FSC_Utils.php

bzr:mapping-version:

v4

bzr:repository-uuid:

1e3b908f-19a9-db11-a64c-001125224ba8

bzr:revision-id:

ohkouchi@loop-az.jp-20100610074421-i3dwjk10nnz0lsqm

bzr:revno:

1959

bzr:revprop:branch-nick:

branches/version-2_4-dev

bzr:root:

branches/version-2_4-dev

bzr:text-parents:

data/class/helper/SC_Helper_CSV.php ohkouchi@loop-az.jp-20100607063506-7aygam8pu7925183
data/class/pages/admin/system/LC_Page_Admin_System_Bkup.php ohkouchi@loop-az.jp-20100607063506-7aygam8pu7925183
data/class/util/SC_Utils.php ohkouchi@loop-az.jp-20100607113809-a2ooznl16n2ko77e

bzr:timestamp:

2010-06-10 16:44:21.206000090 +0900

bzr:user-agent:

bzr2.1.1+bzr-svn1.0.2

svn:original-date:

2010-06-10T07:44:21.206000Z

Message:

CSVダウンロードで"が入っているときのエスケープ処理を修正(#755)

Location:

branches/version-2_4-dev/data/class

Files:

• helper/SC_Helper_CSV.php (modified) (3 diffs)
• pages/admin/system/LC_Page_Admin_System_Bkup.php (modified) (3 diffs)
• util/SC_Utils.php (modified) (1 diff)

branches/version-2_4-dev/data/class/helper/SC_Helper_CSV.php

@@ -266 +266 @@
                 break;
             }
-
-            $tmp = ereg_replace("[\",]", " ", $tmp);
+            $tmp = ereg_replace("\"", "\"\"", $tmp);
             $line .= "\"".$tmp."\",";
         }
@@ -297 +296 @@
             }
 
-            $tmp = ereg_replace("[\",]", " ", $tmp);
+            $tmp = ereg_replace("\"", "\"\"", $tmp);
             $line .= "\"".$tmp."\",";
         }
@@ -320 +319 @@
             }
 
-            $tmp = ereg_replace("[\",]", " ", $tmp);
+            $tmp = ereg_replace("\"", "\"\"", $tmp);
             $line .= "\"".$tmp."\",";
         }

branches/version-2_4-dev/data/class/pages/admin/system/LC_Page_Admin_System_Bkup.php

@@ -240 +240 @@
                     $data = "";
                     foreach($arrData as $data_key => $data_val){
-                        //$val = str_replace("\"", "\\\"", $val);
                         $data .= $this->lfGetCSVList($arrData[$data_key]);
 
@@ -343 +342 @@
             foreach($array as $key => $val) {
                 $val = mb_convert_encoding($val, CHAR_CODE, CHAR_CODE);
-                $val = str_replace("\"", "\\\"", $val);
+                $val = str_replace("\"", "\"\"", $val);
                 $line .= "\"".$val."\",";
             }
@@ -591 +590 @@
             }
             $sql .= " );";
-            $data = str_replace("\\\"", "\"", $data);
             $err = $objQuery->query($sql, $data);
 

branches/version-2_4-dev/data/class/util/SC_Utils.php

@@ -560 +560 @@
             foreach($array as $key => $val) {
                 $val = mb_convert_encoding($val, CHAR_CODE, CHAR_CODE);
+                $val = ereg_replace("\"", "\"\"", $val);
                 $line .= "\"".$val."\",";
             }