Changeset 18283 for branches/comu-ver2/data/class/pages/shopping/LC_Page_Shopping_Complete.php

Timestamp:

2009/09/07 23:48:32 (15 years ago)

Author:

Seasoft

Message:

在庫を減らす処理の改訂

• 不要な分岐を削減
• 不明確な値を例外として扱う

File:

• branches/comu-ver2/data/class/pages/shopping/LC_Page_Shopping_Complete.php (modified) (1 diff)

branches/comu-ver2/data/class/pages/shopping/LC_Page_Shopping_Complete.php

@@ -646 +646 @@
         $objDb = new SC_Helper_DB_Ex();
         
+        if (!SC_Utils_Ex::sfIsInt($quantity)) {
+            $objQuery->rollback();
+            SC_Utils_Ex::sfDispException();
+        }
+        
         $where = "product_id = ? AND classcategory_id1 = ? AND classcategory_id2 = ?";
         $arrRet = $objQuery->select("stock, stock_unlimited", "dtb_products_class", $where, $arrID);
 
-        // 売り切れエラー
-        if(($arrRet[0]['stock_unlimited'] != '1' && $arrRet[0]['stock'] < $quantity) || $quantity == 0) {
+        if (($arrRet[0]['stock_unlimited'] != '1' && $arrRet[0]['stock'] < $quantity) || $quantity == 0) {
+            // 売り切れエラー
             $objQuery->rollback();
             SC_Utils_Ex::sfDispSiteError(SOLD_OUT, "", true);
-        // 無制限の場合、在庫はNULL
-        } elseif($arrRet[0]['stock_unlimited'] == '1') {
-            $sqlval['stock'] = null;
-            $objQuery->update("dtb_products_class", $sqlval, $where, $arrID);
+        }
+        
         // 在庫を減らす
-        } else {
-            $sqlval['stock'] = ($arrRet[0]['stock'] - $quantity);
-            if($sqlval['stock'] == "") {
-                $sqlval['stock'] = '0';
-            }
-            $objQuery->update("dtb_products_class", $sqlval, $where, $arrID);
-        }
+        $arrRawSql = array();
+        $arrRawSql['stock'] = 'stock - ?';
+        $arrRawSqlVal[] = $quantity;
+        $objQuery->update('dtb_products_class', array(), $where, $arrID, $arrRawSql, $arrRawSqlVal);
         
         // 在庫無し商品の非表示対応
         if (NOSTOCK_HIDDEN === true) {
-            // 件数カウントバッチ実行
-            $objDb->sfCategory_Count($objQuery);
+            // 件数カウントバッチ実行
+            $objDb->sfCategory_Count($objQuery);
         }