Changeset 18273

Timestamp:

2009/09/01 12:31:58 (15 years ago)

Author:

Seasoft

Message:

SC_Utils#sfIsInt の改修。

• 「0」をINT型でないと見なしてしまうバグを修正。
• 他の問題点をコメントに記述。

Location:

branches/comu-ver2/data/class

Files:

• helper/SC_Helper_DB.php (modified) (2 diffs)
• util/SC_Utils.php (modified) (1 diff)

branches/comu-ver2/data/class/helper/SC_Helper_DB.php

@@ -829 +829 @@
             $category_id = (int) $category_id;
             $product_id = (int) $product_id;
-            if(SC_Utils_Ex::sfIsInt($category_id) && $this->sfIsRecord("dtb_category","category_id", $category_id)) {
+            if (SC_Utils_Ex::sfIsInt($category_id) && $category_id != 0 && $this->sfIsRecord("dtb_category","category_id", $category_id)) {
                 $this->g_category_id = array($category_id);
-            } else if (SC_Utils_Ex::sfIsInt($product_id) && $this->sfIsRecord("dtb_products","product_id", $product_id, $status)) {
+            } else if (SC_Utils_Ex::sfIsInt($product_id) && $product_id != 0 && $this->sfIsRecord("dtb_products","product_id", $product_id, $status)) {
                 $objQuery = new SC_Query();
                 $where = "product_id = ?";
@@ -1662 +1662 @@
         }
 
-        if(!$this->g_maker_on) {
+        if (!$this->g_maker_on) {
             $this->g_maker_on = true;
             $maker_id = (int) $maker_id;
             $product_id = (int) $product_id;
-            if(SC_Utils_Ex::sfIsInt($maker_id) && $this->sfIsRecord("dtb_maker","maker_id", $maker_id)) {
+            if (SC_Utils_Ex::sfIsInt($maker_id) && $maker_id != 0 && $this->sfIsRecord("dtb_maker","maker_id", $maker_id)) {
                 $this->g_maker_id = array($maker_id);
-            } else if (SC_Utils_Ex::sfIsInt($product_id) && $this->sfIsRecord("dtb_products","product_id", $product_id, $status)) {
+            } else if (SC_Utils_Ex::sfIsInt($product_id) && $product_id != 0 && $this->sfIsRecord("dtb_products","product_id", $product_id, $status)) {
                 $objQuery = new SC_Query();
                 $where = "product_id = ?";

branches/comu-ver2/data/class/util/SC_Utils.php

@@ -261 +261 @@
     }
 
-    // INT型の数値チェック
+    /**
+     *  INT型の数値チェック
+     *  ・FIXME: マイナス値の扱いが不明確
+     *  ・XXX: INT_LENには収まるが、INT型の範囲を超えるケースに対応できないのでは?
+     *  
+     *  @param mixed $value
+     *  @return bool
+     */
+    // 
     function sfIsInt($value) {
-        if($value != "" && strlen($value) <= INT_LEN && is_numeric($value)) {
+        if (strlen($value) >= 1 && strlen($value) <= INT_LEN && is_numeric($value)) {
             return true;
         }